Fix OpenSC compatibility for RSA #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, OpenSC only allows generating a key if the attributes have already been set to the correct key because it doesn't use the algorithm information DO to fetch the list of supported algorithms. |
|
It's still not possible to generate Curve25519 keys however. |
sosthene-nitrokey
force-pushed
the
fix-opensc
branch
from
31f9b23
to
4bcd97c
Compare
sosthene-nitrokey
force-pushed
the
fix-opensc
branch
from
4bcd97c
to
b1c8e2f
Compare
|
There are still some errors with the latest OpenSC versions thought |
Actually, this was due to how I compiled OpenSC and works correctly. With version 0.23-rc2 it actually doesn't have the issue with the attributes. It still doesn't work for curve25519 |
|
For curve25519 it seems OpenSC parses the curve attributes as for XEdDSA, not X25519 and Ed25519 separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opensc inability to generate RSA keys was due to OpenSC trying to set the algorithm attributes to a fixed byte string that was not exactly the one we accepted (because it specifies the Import even for key generation).